Skip to content

enum name changed for logger update reverted - #9922

Merged
JoaoJandre merged 1 commit into
apache:mainfrom
shapeblue:poolTypeNameError
Nov 14, 2024
Merged

enum name changed for logger update reverted#9922
JoaoJandre merged 1 commit into
apache:mainfrom
shapeblue:poolTypeNameError

Conversation

@DaanHoogland

@DaanHooglandDaanHoogland commented Nov 13, 2024

Copy link
Copy Markdown
Contributor

Description

This PR fixes an unintended name change on an enum member for pooltype

Fixes: #9915

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov

codecovBot commented Nov 13, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.04%. Comparing base (f7b7339) to head (044553a).
Report is 6 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (f7b7339) and HEAD (044553a). Click for more details.

HEAD has 1 upload less than BASE
FlagBASE (f7b7339)HEAD (044553a)
unittests10
Additional details and impacted files
@@ Coverage Diff @@## main #9922 +/- ##
============================================
- Coverage 15.80% 4.04% -11.77% 
============================================
Files 5627 392 -5235 Lines 492294 32170 -460124 Branches 62198 5677 -56521 ============================================
- Hits 77824 1301 -76523 + Misses 405946 30721 -375225 + Partials 8524 148 -8376 
FlagCoverage Δ
uitests4.04% <ø> (ø)
unittests?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slavkapslavkap left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@JoaoJandre

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11558

@JoaoJandre

Copy link
Copy Markdown
Contributor

@DaanHoogland@sureshanaparti could we run the CI here?

@DaanHoogland

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-11776)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 55091 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9922-t11776-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

TestResultTime (s)Test File
test_01_secure_vm_migrationError398.00test_vm_life_cycle.py

@weizhouapacheweizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@JoaoJandre
JoaoJandre merged commit b75742d into apache:mainNov 14, 2024
@DaanHoogland
DaanHoogland deleted the poolTypeNameError branch November 14, 2024 14:43
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Nov 20, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when using CLVM in KVM Hypervisor

6 participants

@DaanHoogland@JoaoJandre@blueorangutan@GutoVeronezi@slavkap@weizhouapache