Uh oh!
There was an error while loading. Please reload this page.
UI: Allow accounts of the User type to add other accounts or users to projects through UI - #9927
Merged
DaanHoogland merged 5 commits intoNov 28, 2024
Conversation
bernardodemarco
commented
Nov 14, 2024
MemberAuthor
bernardodemarco
requested review from
DaanHoogland, rajujith and weizhouapacheNovember 14, 2024 11:53
blueorangutan
commented
Nov 14, 2024
@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## 4.19 #9927 +/- ##
=========================================
Coverage 15.10% 15.11% - Complexity 11220 11225 +5
=========================================
Files 5404 5404 Lines 473460 473513 +53 Branches 57728 57738 +10 =========================================
+ Hits 71525 71558 +33 - Misses 393941 393954 +13 - Partials 7994 8001 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
blueorangutan
commented
Nov 14, 2024
UI build: ✔️ |
DaanHoogland
approved these changes
Nov 14, 2024
DaanHoogland
left a comment
Contributor
There was a problem hiding this comment.
clgtm, tested in qa.c.c
winterhazel
approved these changes
Nov 14, 2024
winterhazel
left a comment
Member
There was a problem hiding this comment.
LGTM, tested in a local lab and was able to add accounts and users to a project in a User type account via the UI.
DaanHoogland added a commit
that referenced
this pull request
Dec 3, 2024
* 4.20: UI: Tooltip on the host information card to display the CPU speed in MHz and the memory value in MB (to 3 decimal places) (#9971) UI: Allow accounts of the `User` type to add other accounts or users to projects through UI (#9927) enable to create VPC portfowarding rules with source cidr (#7081) Add new column `last_id` to the table volumes (#9759) Allow VMWare import via another host (#9787) Linstor: add support for ISO block devices and direct download (#9792) get expunged VM data for job result (#9949) fix section divider display on auth page (#9966)
dhslove pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Dec 12, 2024
…to projects through UI (apache#9927)
dhslove pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Dec 12, 2024
* 4.20: UI: Tooltip on the host information card to display the CPU speed in MHz and the memory value in MB (to 3 decimal places) (apache#9971) UI: Allow accounts of the `User` type to add other accounts or users to projects through UI (apache#9927) enable to create VPC portfowarding rules with source cidr (apache#7081) Add new column `last_id` to the table volumes (apache#9759) Allow VMWare import via another host (apache#9787) Linstor: add support for ISO block devices and direct download (apache#9792) get expunged VM data for job result (apache#9949) fix section divider display on auth page (apache#9966)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, to add a user or account to a project through UI, a select input field is rendered, displaying the accounts and users that the caller has access to as options. As a result, users with an account of the
Usertype are unable to add other accounts or users to a project, since they don't have access to other accounts or users and no options are available to be selected in the input field.This PR modifies the input field to allow users to both select from the available options and manually enter the account name or username they wish to add to the project.
Fixes#9774
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Adding an account by selecting an option available in the dropdown
Adding a user by entering their username in the input field
How Has This Been Tested?
d1, a domain admin (d1) and two normal users (u1-d1andu2-d1) belonging to the domain.d1account.d1account can select accounts and users of their domain to add them to the project.u1-d1account to the project as an admin.u1-d1account, accessed the project and added the useru2-d1to the project.