add-some-Unit-Tests Added some Unit Tests to increase code coverage.

[TheRealHaui]

I have added some Unit Tests to increase code coverage and want to contribute them.

[TheRealHaui]

@bodewig
Could you be so kind an review my contribution and - of course - most of all pull it into the code base.

[coveralls]

Coverage increased (+0.2%) to 84.524% when pulling 2f45456 on TheRealHaui:add-some-Unit-Tests into 0d8ab18 on apache:master.

[bodewig]

Fortunately I'm not the only one who could merge this :-)

More seriously, it may take a bit of time until I get there, but I will.

[bodewig]

Thanks @TheRealHaui

I agree with your comment on ChecksumCalculatingInputStreamTest#testGetValueThrowsNullPointerException this looks like a bug. So I'd rather remove the test and see the bug fixed. Do you want to take a stab?

Also, the Commons Compress community has decided to not use author tags, I'd have to strip yours before merging the PR. Could you please remove them yourself if you modify this PR? Feel free to add yourself as a contributor to the POM.

[coveralls]

Coverage increased (+0.3%) to 84.657% when pulling 96ca8ce on TheRealHaui:add-some-Unit-Tests into 0d8ab18 on apache:master.

[coveralls]

Coverage increased (+0.3%) to 84.673% when pulling be0f11f on TheRealHaui:add-some-Unit-Tests into 0d8ab18 on apache:master.

[coveralls]

Coverage increased (+0.3%) to 84.673% when pulling 3b46bb5 on TheRealHaui:add-some-Unit-Tests into 0d8ab18 on apache:master.

[TheRealHaui]

@bodewig
Thank you for your kind response!
Really appreciate that!

Therefore I've made all the changes you requested/proposed.
And of course added myself as a contributor as heavily requested by you.
Really couldn't disappoint you regarding that special topic. :-)

Furthermore I've created a Jira Task for the bespoken bug: https://issues.apache.org/jira/browse/COMPRESS-412
And fixed it in an own branch which I've commited, created tests for and pushed too.
And which pull request I am going to link here in the next comment after I've created it.

[TheRealHaui]

Link to the pull request: #35

[coveralls]

Coverage increased (+0.4%) to 84.713% when pulling e0500a6 on TheRealHaui:add-some-Unit-Tests into 0d8ab18 on apache:master.

[bodewig]

Thanks a lot.

[sesuncedu]

It's usually not a good idea to convert an arbitrary byte array to a string, as on can't rely on a specific default charset, and you may end up with characters mangled /mapped.

I thinkThat hamcrest has array matchers; if not, assertTrue(Arrays.equals(exp,act)) should be OK.
I can't remember if there's an assertEquals for byte[]

[bodewig]

Thank you for catching this. I've reformulated the test with commit b53ead4 - I think we are not that much interested in the exact bytes created but rather that using write creates a valid XZ output.

JUnit's Assert class contains assertArrayEquals.

[TheRealHaui]

@bodewig
You're welcome, was a pleasure!