Skip to content

Display max memory size is not respected if repr_rows < min_rows #1362

Description

@timsaucer

Describe the bug

Our default values of repr_rows is 10 and min_rows is 20. This causes the clause rows_so_far < min_rows to never return False

To Reproduce

Print any large dataframe (>2 Mb). The entire frame is collected, even if it is not shown.

Expected behavior

Stop the stream when the memory limit is reached.

Additional context

It seems like min_rows should always be <= repr_rows. Maybe we should call it max_rows instead of repr_rows? The documentation also states "If you want a specific number of rows, set min_rows == max_rows."

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions