Skip to content

Issue #39 - Add .asf.yaml for asf-site - #105

Closed
martin-g wants to merge 5 commits into
apache:masterfrom
martin-g:asf-site-subdir
Closed

Issue #39 - Add .asf.yaml for asf-site#105
martin-g wants to merge 5 commits into
apache:masterfrom
martin-g:asf-site-subdir

Conversation

@martin-g

@martin-gmartin-g commented Dec 5, 2022

Copy link
Copy Markdown
Member

Which issue does this PR close?

Issue #39 .

Rationale for this change

To auto-update the documentation whenever something is pushed to the asf-site branch.

What changes are included in this PR?

Adds publish section in .asf.yaml so that it publishes to https://arrow.apache.org/datafusion-python

Are there any user-facing changes?

No

andygroveand others added 2 commits November 30, 2022 08:55
@andygrove
DataFusion Python 0.7.0 Documentation
3b70cf2
@martin-g
Issueapache#39- Add .asf.yaml for asf-site
7b78011
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g

martin-g commented Dec 5, 2022

Copy link
Copy Markdown
MemberAuthor

Related-to: #104

@martin-g

martin-g commented Dec 5, 2022

Copy link
Copy Markdown
MemberAuthor

@kou Please review!

@martin-gmartin-g mentioned this pull request Dec 5, 2022
Merged
kou
kou reviewed Dec 6, 2022
View reviewed changes
Comment thread.asf.yaml Outdated
Comment thread.asf.yaml Outdated
commits: commits@arrow.apache.org
issues: github@arrow.apache.org
pullrequests: github@arrow.apache.org
jira_options: link label worklog

@koukouDec 6, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this because we don't use Jira.

@martin-gmartin-gDec 6, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it!

Comment thread.asf.yaml Outdated
martin-gand others added 3 commits December 6, 2022 09:15
@martin-g@kou
Change 'issues' to 'issues_status' in .asf.yaml
03aea0b
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@martin-g@kou
Change homepage to datafusion-python in .asf.yaml
6473df8
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@martin-g
Remove JIRA related options
32251b6
kou
kou approved these changes Dec 6, 2022
View reviewed changes

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou
kou changed the base branch from asf-site to masterDecember 6, 2022 08:25
@koukou closed this Dec 6, 2022
@kou

kou commented Dec 6, 2022

Copy link
Copy Markdown
Member

Oh, sorry. This pull request was closed...
We need to put .asf.yaml to the default branch (master) not asf-site.
I changed the base branch to master then this pull request was closed...
Could you create one more pull request that uses master as the base branch?

@kou

kou commented Dec 6, 2022

Copy link
Copy Markdown
Member

Sorry... I was wrong...
We need to put .asf.yaml to asf-site... Could you create the same pull request again? Sorry...

https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Publishingabranchtoyourprojectwebsite

Note: although publishing the asf-site branch used to work without .asf.yaml being present, since May 2021 that file MUST be present at the root of the branch you wish to publish. for everything (including soft purging the CDN cache on updates) to work correctly.

@martin-gmartin-g mentioned this pull request Dec 6, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@koukoukou approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@martin-g@kou@andygrove