Uh oh!
There was an error while loading. Please reload this page.
Allow plain Python literals in regexp function wrappers - #1493
Allow plain Python literals in regexp function wrappers#1493renato2099 wants to merge 6 commits into
Conversation
Making ruff happy
Uh oh!
There was an error while loading. Please reload this page.
timsaucer
left a comment
There was a problem hiding this comment.
This is a nice addition. I think we should update the docstrings to not have lit() since we can take these values directly now.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
timsaucer
commented
Apr 14, 2026
Also worth noting is I've been working on a skill that will do these in a more automated way: #1484 It might be worth comparing what you came up with vs the agent. |
oh very cool @timsaucer ! |
8d7ad5e to
ad0b3d6Comparetimsaucer
commented
May 27, 2026
Closing in favor of the already merged #1484 This is great work! Sorry we overlapped. |
Which issue does this PR close?
Closes#1446.
Rationale for this change
Make regex functions more pythonic
What changes are included in this PR?
Changes to regex functions such that we can improve their usability by making them more pythonic
Are there any user-facing changes?
Regex functions are more pythonic now