Skip to content

fix: remove todo from indexed field key#1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BharatDeva wants to merge 1 commit into
base:main
Choose a base branch
from
+4 −1
Open

fix: remove todo from indexed field key #1667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion crates/core/src/expr/indexed_field.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ use datafusion::logical_expr::expr::{GetFieldAccess, GetIndexedField};
use pyo3::prelude::*;

use super::literal::PyLiteral;
use crate::errors::py_unsupported_variant_err;
use crate::expr::PyExpr;

#[pyclass(
Expand DownExpand Up@@ -68,7 +69,9 @@ impl PyGetIndexedField {
fn key(&self) -> PyResult<PyLiteral> {
match &self.indexed_field.field {
GetFieldAccess::NamedStructField { name, .. } => Ok(name.clone().into()),
_ => todo!(),
GetFieldAccess::ListIndex { .. } | GetFieldAccess::ListRange { .. } => Err(
py_unsupported_variant_err("GetIndexedField.key is only supported for struct fields"),
),
}
}

Expand Down
Loading