Skip to content

Add read_json to SessionContext - #56

Merged
jimexist merged 8 commits into
apache:masterfrom
larskarg:read-json
Nov 2, 2022
Merged

Add read_json to SessionContext#56
jimexist merged 8 commits into
apache:masterfrom
larskarg:read-json

Conversation

@larskarg

@larskarglarskarg commented Oct 12, 2022

Copy link
Copy Markdown
Contributor

Related to #28.

MR adds functionality to read json files. I have added some tests cases (not all parameters are covered). Please let me know if the test cases are sufficient and/or if I should store the test data differently.

Example:

importdatafusionctx=datafusion.SessionContext()
df=ctx.read_json("data.json")
df.show()

Comment threadsrc/context.rs Outdated

@francis-dufrancis-du left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andygroveandygrove left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @larskarg

@andygrove

Copy link
Copy Markdown
Member

@larskarg It looks like there is a Python lint issue and also needs an upmerge

@larskarg

larskarg commented Oct 13, 2022

Copy link
Copy Markdown
ContributorAuthor

@andygrove

Upmerge done.

I did also run

flake8 --exclude venv --ignore=E501
black --line-length 79 --diff --check .

locally but didn't see any Python lint issues. Unfortunately, I cannot trigger the github workflow as a first-time contributor. Can you please point me to the Python lint issue? Thanks.

Comment threadsrc/context.rs Outdated
Comment threaddatafusion/tests/data_test_context/data.json Outdated
@jimexist
jimexist merged commit 12bb587 into apache:masterNov 2, 2022
@francis-du

Copy link
Copy Markdown
Contributor

🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@larskarg@andygrove@francis-du@ei-grad@jimexist@isidentical