Uh oh!
There was an error while loading. Please reload this page.
Upgrade datafusion 39 - #728
Merged
Merged
Conversation
…0.10.1 `datafusion-common` also depends on `pyo3`, so they need to be upgraded together.
datafusion replaced Expr::GetIndexField with a FieldAccessor trait. Ref apache/datafusion#10568 Ref apache/datafusion#10769
The field `func_name` was changed to `func` as part of removing `ScalarFunctionDefinition` upstream. Ref apache/datafusion#10325
This silences pyo3's deprecation warnings for its new Bounds api. It's the 1st step of the migration, and should be removed before merge. Ref https://pyo3.rs/v0.21.0/migration#from-020-to-021
AggregateUDF expressions now have a builder API design, which removes arguments like filter and order_by Ref apache/datafusion#10545 Ref apache/datafusion#10492
Michael-J-Ward
marked this pull request as ready for review
June 14, 2024 16:59
Closed
andygrove
approved these changes
Jun 14, 2024
andygrove
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks @Michael-J-Ward!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #727
Closes#670
Closes#677
Closes#665
Note: this performs the bulk of the upgrade, but see #727 for things to clean up before releasing.
What changes are included in this PR?
Datafusion, pyo3, and object_store deps are upgraded.
Are there any user-facing changes?
Upstream datafusion continues migrating from built-in functions to UDFs, with the focus now moving to
aggregatefunctions.pyarrowhad a bug in itsIntervalDayTimeandIntervalMonthDayNanodefinitions, so if users had hacked around that like we did in ourtpchexamples, things will change unexpectedly. Refer to #665 for details.