Uh oh!
There was an error while loading. Please reload this page.
feat: expose between - #868
Conversation
| expr.into() | ||
| } | ||
| #[pyo3(signature = (low, high, negated=false))] |
There was a problem hiding this comment.
With the introduction of the python wrappers, we've been preferring to avoid #[pyo3(signature = ...)] annotations for simple defaults and let the python wrappers handle them.
(I see that I left that out of the guidelines, I'll throw a quick PR for that.)
There was a problem hiding this comment.
FYI for optionals we might have to have these signatures in when we upgrade to pyo3 0.22. It's part of the DF42 update PR that's up
There was a problem hiding this comment.
So, do you folks think I should remove it?
There was a problem hiding this comment.
I think it should be kept in as we'll have to add it anyways once the pyo3 0.22 upgrade hits #867
There was a problem hiding this comment.
Yes, leave it in for now.
Which issue does this PR close?
Closes#809.
Are there any user-facing changes?
Yes