Uh oh!
There was an error while loading. Please reload this page.
Upgrade to Datafusion 43 - #905
Conversation
6a36cfd to
7255ec2CompareIt was removed upstream. Ref: apache/datafusion#13076
7255ec2 to
d86520bCompared86520b to
f7f518cCompareMichael-J-Ward
commented
Oct 28, 2024
For context on the On this branch, the >/home/mike/workspace/datafusion-python/dev/python/tests/test_udwf.py(143)evaluate_all()
->results= []
(Pdb) values
[<pyarrow.lib.Int64Arrayobjectat0x7fff8ec772e0>
[
0,
1,
2,
3,
4,
5,
6
]]On |
timsaucer
commented
Oct 28, 2024
Do you need help troubleshooting the test? |
Michael-J-Ward
commented
Oct 28, 2024
@timsaucer - yes, if you wouldn't mind. Here's where I'm at.
RUST: evaluating partition_evaluator_args: PartitionEvaluatorArgs { input_exprs: [Column { name: "a", index: 0 }, Column { name: "b", index: 1 }], input_types: [Int64, Int64], is_reversed: false, ignore_nulls: false }But then RUST: evaluating evaluate_all with 1 value arrays: [PrimitiveArray<Int64>[ 0, 1, 2, 3, 4, 5, 6,]]My next step would be to dig deeper into the upstream machinery, so I'd appreciate if you could take a quick sanity check before that. |
timsaucer
commented
Nov 9, 2024
Ok, I think this is ready to merge. @Michael-J-Ward do you want to look over the changes I added in to account for the new string views? |
Michael-J-Ward
commented
Nov 10, 2024
@timsaucer - thanks for finishing this up! I think it's good to go. Especially since this 1st upgrade PR is primarily for the dependencies. |
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
Python Changes:
PyLimitmethods forskipandfetchbecause upstreamLimitnow returns expressions instead of constantsCrossjoinexpression was removed upstreamTODO
SmoothTwoColumntest (theevaluate_allpython method is only receiving theacolumn).