Uh oh!
There was an error while loading. Please reload this page.
Support for unquoted hyphenated identifiers on bigquery - #1109
Conversation
Pull Request Test Coverage Report for Build 7632995071
💛 - Coveralls |
alamb
left a comment
There was a problem hiding this comment.
Thank you for the contribution @jmhain -- this is wild
This adds support for unquoted hyphenated identifiers on bigquery, e.g. select * from foo-bar f join baz-qux b on f.id = b.id. These are only allowed in contexts where they are unambiguous, such as in a FROM or JOIN clause. (There may be other cases where they are allowed, I only tested these two.)
Wow the craziness of sql dialects never ceases to amaze me. Big query, why? LOL
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jmhain
commented
Jan 23, 2024
@alamb Thanks for the prompt feedback! I pushed a couple commits incorporating your suggestions.
lol this was my reaction as well |
alamb
commented
Jan 24, 2024
Thanks again @jmhain |
This adds support for unquoted hyphenated identifiers on bigquery, e.g.
select * from foo-bar f join baz-qux b on f.id = b.id. These are only allowed in contexts where they are unambiguous, such as in aFROMorJOINclause. (There may be other cases where they are allowed, I only tested these two.)