Skip to content

Fix MySQL parsing of GRANT, REVOKE, and CREATE VIEW - #1538

Merged
iffyio merged 22 commits into
apache:mainfrom
mvzink:mysql-users
Jan 9, 2025
Merged

Fix MySQL parsing of GRANT, REVOKE, and CREATE VIEW#1538
iffyio merged 22 commits into
apache:mainfrom
mvzink:mysql-users

Conversation

@mvzink

@mvzinkmvzink commented Nov 20, 2024

Copy link
Copy Markdown
Contributor
  • Support MySQL style 'user'@'host' syntax.
  • Support wildcards on grant objects: *.*.
  • Make CASCADE/RESTRICT in revoke statements optional since MySQL doesn't accept it.
  • Support optional MySQL parameters for create view: algorithm, definer (requires user@host syntax), and security context.

@mvzink
Tokenize at signs separately from subsequent strings
abd971d
This is needed for parsing MySQL-style `'user'@'host'` grantee syntax.
As far as I can tell, no dialect allows quotes or backticks as part of
an identifier (regardless of whether it starts with `@`) without other
specific syntax (e.g. nested in another quote style and thus not
starting with `@`), so this shouldn't adversely affect non-MySQL
dialects.
@mvzink
Fix parsing GRANT/REVOKE for MySQL
9dc0d9e
Introduces a new `Grantee` enum to differentiate bare identifiers (every
other database: `root`) from user/host pairs (MySQL: `'root'@'%'`).
While we're here, make the CASCADE/RESTRICT syntax for REVOKE optional
since Postgres doesn't require it and MySQL doesn't allow it.
Add support for MySQL wildcard object syntax: `GRANT ALL ON *.* ...`
@mvzink
Parse MySQL CREATE VIEW parameters
64669ed
@mvzink

mvzink commented Nov 20, 2024

Copy link
Copy Markdown
ContributorAuthor

Would appreciate feedback on the naming the MySQL-specific params types (would a generic/non-branded name be better?) and the API change for wildcard support (didn't want to change all 107 parse_object_name callsites for an option that is so niche, but happy to be convinced otherwise).

@mvzinkmvzink mentioned this pull request Nov 20, 2024
Merged
iffyio
iffyio reviewed Nov 24, 2024
View reviewed changes
Comment threadtests/sqlparser_mysql.rs
Comment threadtests/sqlparser_mysql.rs
Comment threadsrc/parser/mod.rs Outdated
Comment threadsrc/parser/mod.rs Outdated
Comment threadsrc/tokenizer.rs
Comment threadsrc/parser/mod.rs Outdated
Comment threadsrc/parser/mod.rs Outdated
Comment threadtests/sqlparser_mysql.rs
Comment threadtests/sqlparser_mysql.rs Outdated
Comment threadsrc/ast/mod.rs Outdated
iffyio
iffyio reviewed Nov 28, 2024
View reviewed changes
Comment threadsrc/tokenizer.rs
Comment threadsrc/ast/mod.rs Outdated
iffyio
iffyio reviewed Dec 23, 2024
View reviewed changes

@iffyioiffyio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mvzink! Left some minor comments I think with those and resolving conflicts on the branch this looks good to me!

Comment threadsrc/parser/mod.rs Outdated
Comment threadsrc/parser/mod.rs Outdated
Comment threadsrc/parser/mod.rs Outdated
Comment threadsrc/parser/mod.rs Outdated
iffyio
iffyio approved these changes Dec 27, 2024
View reviewed changes

@iffyioiffyio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mvzink
cc @alamb

@iffyio

iffyio commented Dec 27, 2024

Copy link
Copy Markdown
Contributor

@mvzink it seems there's a couple conflicts in the branch could you take a look when you have some time?

@iffyio

iffyio commented Jan 8, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Hi @mvzink sorry I just noticed this was since rebased, could I ask for another rebase and if you could just ping me when its done I'll prio merging it to avoid further conflicts 🙏

@mvzink

mvzink commented Jan 8, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@iffyio resolved, but there were some significant changes to grantee parsing by @yoavcloud so maybe he should take a look too.

mvzink
mvzink commented Jan 8, 2025
View reviewed changes
Comment threadsrc/parser/mod.rs Outdated
@mvzink

mvzink commented Jan 9, 2025

Copy link
Copy Markdown
ContributorAuthor

@iffyio I think this is good to go.

iffyio
iffyio approved these changes Jan 9, 2025
View reviewed changes

@iffyioiffyio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mvzink!
cc @alamb

@iffyio
iffyio merged commit 4fdf5e1 into apache:mainJan 9, 2025
@mvzink
mvzink deleted the mysql-users branch January 10, 2025 17:21
ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Apr 10, 2025
@mvzink@ayman-sigma
Fix MySQL parsing of GRANT, REVOKE, and CREATE VIEW (apache#1538)
2210860
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoavcloudyoavcloudyoavcloud left review comments
@iffyioiffyioiffyio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mvzink@iffyio@yoavcloud