Uh oh!
There was an error while loading. Please reload this page.
Redshift: Fix parsing for quoted numbered columns - #1576
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| .dialect | ||
| .nested_quote_start(quote_start, chars.peekable.clone()) | ||
| { | ||
| chars.next(); // consume the opening quote |
There was a problem hiding this comment.
This code is RedShift specific (nested quotation). The same time tokenisation of quoted identifier is a method of tokeniser and this is a reason of implemented it here.
Let me know if you have a good idea how makes this code more explicit.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
iffyio
left a comment
There was a problem hiding this comment.
LGTM! Thanks @7phs@bombsimon
cc @alamb
Quoted identifiers allow the use of any characters and can start with any character, including digits. For example:
However, the tokenizer cannot parse such types of quoted identifiers in the case of Redshift. This issue is related to the handling of potential identifiers in PartiQL.
This merge request (MR) clarifies the behavior of quoted identifiers in PartiQL and fixes the parsing of quoted identifiers for Redshift.
I added an additional case of a valid JSON path in a specific unit test to ensure that JSON path parsing is not broken.