Uh oh!
There was an error while loading. Please reload this page.
Add CREATE TABLE AS support - #206
Conversation
Pull Request Test Coverage Report for Build 144885262
💛 - Coveralls |
nickolay
left a comment
There was a problem hiding this comment.
Thanks! I've added my thoughts inline.. Of those I'd like query.is_none() to be fixed before merging, for the rest I'm curious what you think.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Add a test for CTAS with schema and note it's bigquery-only Add a constraints-only schema and note it's postgresql-only Simplify the parse_create_table_if_not_exists test to focus on `IF NOT EXISTS` parsing
nickolay
commented
Jun 23, 2020
I just realized that I also wanted to have a test for that and for I think this is ready to be merged, what do you think? |
Dandandan
commented
Jun 23, 2020
I think so too! Thanks a lot :) |
nickolay
commented
Jun 23, 2020
Excellent, thanks! I summarized the changes here in the commit message as follows:
|
Issue: https://github.com/andygrove/sqlparser-rs/issues/205