Uh oh!
There was an error while loading. Please reload this page.
Fixing location for extrenal tables - #2108
Merged
Merged
Conversation
iffyio
reviewed
Nov 29, 2025
Comment on lines
+570
to
+573
| #[test] | ||
| fn parse_create_external_table_without_location() { | ||
| hive().verified_stmt("CREATE EXTERNAL TABLE t (c INT)"); | ||
| } |
Contributor
There was a problem hiding this comment.
Can we add this entry to this existing test case instead?
romanoffforce-pushed
the
external_table_location_fix
branch
from
December 1, 2025 18:07
37581a6 to
cca494eCompare
romanoffforce-pushed
the
external_table_location_fix
branch
from
December 1, 2025 18:08
cca494e to
69981a2Compareiffyio
approved these changes
Dec 3, 2025
Uh oh!
There was an error while loading. Please reload this page.
ayman-sigma pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Location isn't required for external tables for hive. Example of query:
Spec:
https://hive.apache.org/docs/latest/language/languagemanual-ddl/?utm_source=chatgpt.com#external-tables
It says:
The EXTERNAL keyword lets you create a table and provide a LOCATION so that Hive does not use a default location. It's not very clear, but if location is not specified, it will provide default location.