Uh oh!
There was an error while loading. Please reload this page.
Fixed transaction handling for snowflake - #2263
Merged
Merged
Conversation
iffyio
reviewed
Mar 5, 2026
| || parser.peek_keyword(Keyword::WORK) | ||
| || parser.peek_keyword(Keyword::NAME) | ||
| || parser.peek_token().token == Token::SemiColon | ||
| || parser.peek_token().token == Token::EOF |
Contributor
There was a problem hiding this comment.
can we add a test case with only a begin keyword (for the EOF case)?
| // Snowflake supports both `BEGIN TRANSACTION` and `BEGIN ... END` blocks. | ||
| // If the next keyword indicates a transaction statement, let the | ||
| // standard parse_begin() handle it. | ||
| if parser.peek_keyword(Keyword::TRANSACTION) |
Contributor
There was a problem hiding this comment.
can we use parser.peek_one_of_keywords() and parser.peek_token_ref() for the two cases to simplify or make the op less expensive?
romanoff
commented
Mar 5, 2026
Author
@iffyio Updated. Thank you |
iffyio
approved these changes
Mar 9, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample query:
Spec: https://docs.snowflake.com/en/sql-reference/sql/begin