Skip to content

Fixed stage name parsing for snowflake - #2265

Merged
iffyio merged 3 commits into
apache:mainfrom
romanoff:fix_stage_name_parsing_for_snowflake
Mar 13, 2026
Merged

Fixed stage name parsing for snowflake#2265
iffyio merged 3 commits into
apache:mainfrom
romanoff:fix_stage_name_parsing_for_snowflake

Conversation

@romanoff

Copy link
Copy Markdown

Fixed special characters in stage name parsing for snowflake
Example queries:

SELECT*FROM @stage/day=18/23.parquet;
SELECT*FROM @stage/0:18:23/23.parquet;

Spec: https://docs.snowflake.com/en/user-guide/querying-stage

Comment threadtests/sqlparser_snowflake.rs Outdated
fn test_snowflake_stage_name_with_special_chars() {
// Stage path with '=' (Hive-style partitioning)
let sql = "SELECT * FROM @stage/day=18/23.parquet";
let stmt = snowflake().parse_sql_statements(sql).unwrap();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use the one_statement_parse_to (or verified_stmt if that works) for the tests?

@romanoff

Copy link
Copy Markdown
Author

@iffyio Updated. Thank you

@iffyioiffyio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @romanoff!

@iffyio
iffyio added this pull request to the merge queueMar 13, 2026
Merged via the queue into apache:main with commit 9d5a171Mar 13, 2026
10 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@romanoff@iffyio