Uh oh!
There was an error while loading. Please reload this page.
Fixed create snapshot table for bigquery - #2269
Merged
iffyio merged 3 commits intoMar 13, 2026
Merged
Conversation
iffyio
reviewed
Mar 9, 2026
| self.iceberg = iceberg; | ||
| self | ||
| } | ||
| /// Set `SNAPSHOT` table flag (BigQuery). |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Set `SNAPSHOT` table flag (BigQuery). | |
| /// Set `SNAPSHOT` table flag. |
| pub volatile: bool, | ||
| /// Iceberg-specific table flag. | ||
| pub iceberg: bool, | ||
| /// BigQuery `SNAPSHOT` table flag. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// BigQuery `SNAPSHOT` table flag. | |
| /// `SNAPSHOT` table flag. |
| pub volatile: bool, | ||
| /// `ICEBERG` clause | ||
| pub iceberg: bool, | ||
| /// BigQuery `SNAPSHOT` clause |
Contributor
There was a problem hiding this comment.
Suggested change
| /// BigQuery `SNAPSHOT` clause | |
| /// `SNAPSHOT` clause |
| && self.parse_one_of_keywords(&[Keyword::PERSISTENT]).is_some(); | ||
| let create_view_params = self.parse_create_view_params()?; | ||
| if self.parse_keyword(Keyword::TABLE) { | ||
| if self.parse_keywords(&[Keyword::SNAPSHOT, Keyword::TABLE]) { |
Contributor
There was a problem hiding this comment.
Suggested change
| ifself.parse_keywords(&[Keyword::SNAPSHOT,Keyword::TABLE]){ | |
| ifself.peek_keywords(&[Keyword::SNAPSHOT,Keyword::TABLE]){ |
thinking we can peek here so that the parse_create_snapshot_table() function is standalone
| .build()) | ||
| } | ||
| /// Parse BigQuery `CREATE SNAPSHOT TABLE` statement. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Parse BigQuery `CREATE SNAPSHOT TABLE` statement. | |
| /// Parse `CREATE SNAPSHOT TABLE` statement. |
I'm thinking in general we can avoid inlining the dialect in the description (the doc links provide context on which dialects support the syntax). Otherwise it becomes confusing/misleading over time documentation wise as multiple dialects support the same or part of the syntax
| #[test] | ||
| fn test_create_snapshot_table() { | ||
| bigquery().verified_stmt("CREATE SNAPSHOT TABLE dataset_id.table1 CLONE dataset_id.table2"); |
Contributor
There was a problem hiding this comment.
Suggested change
| bigquery().verified_stmt("CREATE SNAPSHOT TABLE dataset_id.table1 CLONE dataset_id.table2"); | |
| bigquery_and_generic().verified_stmt("CREATE SNAPSHOT TABLE dataset_id.table1 CLONE dataset_id.table2"); |
can the tests cover generic as well?
romanoffforce-pushed
the
fix_create_snapshot_table_for_bigquery
branch
from
March 9, 2026 23:43
87e38a1 to
53944f4Compareromanoff
commented
Mar 9, 2026
Author
Thanks @iffyio. Updated |
iffyio
approved these changes
Mar 13, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample query:
Spec: https://docs.cloud.google.com/bigquery/docs/reference/standard-sql/data-definition-language#create_snapshot_table_statement