Skip to content

Rename sqlparser_derive to sqlparser_procmacro, document features - #775

Closed
alamb wants to merge 1 commit into
apache:mainfrom
alamb:alamb/derive_cleanup
Closed

Rename sqlparser_derive to sqlparser_procmacro, document features#775
alamb wants to merge 1 commit into
apache:mainfrom
alamb:alamb/derive_cleanup

Conversation

@alamb

Copy link
Copy Markdown
Contributor

Follow on from #765

rename crate to sqlparser_procmacro to be more consistent with other crates in the rust ecosystem

@alamb

Copy link
Copy Markdown
ContributorAuthor

I plan to merge this once CI passes as I then plan to add CI tests for the other crate features

@alamb

Copy link
Copy Markdown
ContributorAuthor

cc @tustvold

@alambalamb mentioned this pull request Dec 28, 2022
@tustvold

Copy link
Copy Markdown
Contributor

_derive is more consistent with the ecosystem as whole for a derive macro?

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 3795008836

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.985%

TotalsCoverage Status
Change from base Build 3794845435:0.0%
Covered Lines:13007
Relevant Lines:15127

💛 - Coveralls

@alamb

Copy link
Copy Markdown
ContributorAuthor

@tustvold notes prior art serde_derive, parquet_derive, etc -- will leave this alone

@alambalamb closed this Dec 28, 2022
@alamb
alamb deleted the alamb/derive_cleanup branch December 28, 2022 15:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alamb@tustvold@coveralls