Skip to content

feat: add DuckDB dialect - #878

Merged
alamb merged 9 commits into
apache:mainfrom
eitsupi:duckdb-int-div
May 18, 2023
Merged

feat: add DuckDB dialect#878
alamb merged 9 commits into
apache:mainfrom
eitsupi:duckdb-int-div

Conversation

@eitsupi

@eitsupieitsupi commented May 10, 2023

Copy link
Copy Markdown
Contributor

Close#873

Add DuckDB dialect and support DuckDB's // operator.

@eitsupi

eitsupi commented May 10, 2023

Copy link
Copy Markdown
ContributorAuthor

Perhaps there is quite a lack of testing for dialects here.

I am not very experienced with this repository and DuckDB, so it would be great if someone could help me with this.

alamb
alamb reviewed May 17, 2023
View reviewed changes

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @eitsupi !

Perhaps there is quite a lack of testing for dialects here.

I think you need to add DuckDbDialect to the list in the following location and the new DuckDbDialect will be well covered by tests/sqlparser_common.rs

https://github.com/sqlparser-rs/sqlparser-rs/blob/4559d87a824a6a268a350d02e63c51b77e41bd34/src/test_utils.rs#L158-L173

Comment threadsrc/ast/operator.rs
@alamb

alamb commented May 17, 2023

Copy link
Copy Markdown
Contributor

This is looking pretty good @eitsupi -- it has a conflict that needs to be resolved and I think the test needs a little updating but otherwise it is ready to go

alamb
alamb reviewed May 17, 2023
View reviewed changes
Comment threadsrc/tokenizer.rs Outdated
@coveralls

coveralls commented May 17, 2023•
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 5014470042

  • 45 of 48(93.75%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 86.186%
Changes Missing CoverageCovered LinesChanged/Added Lines%
src/dialect/duckdb.rs5683.33%
src/parser.rs8988.89%
src/tokenizer.rs2366.67%
TotalsCoverage Status
Change from base Build 5006157133:0.02%
Covered Lines:14394
Relevant Lines:16701
💛 - Coveralls

@eitsupi

eitsupi commented May 18, 2023

Copy link
Copy Markdown
ContributorAuthor

Thank you for your review!
Please let me know if there is anything still missing.

alamb
alamb approved these changes May 18, 2023
View reviewed changes

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me -- thank you @eitsupi

@alamb
alamb merged commit 33b12ac into apache:mainMay 18, 2023
@eitsupi
eitsupi deleted the duckdb-int-div branch May 18, 2023 22:34
serprex pushed a commit to serprex/sqlparser-rs that referenced this pull request Nov 6, 2023
@iskakaushik@AviRaboah
@pawel-big-lebowski@alamb@aljazerzen@aprimadi@okue@ankane@mustafasrepo@Jefffrey@max-sixty@eitsupi@mobuchowski@berkaysynnada@ozankabak@dependabot
Merge Upstream (apache#6)
52482b3
* Support identifiers beginning with digits in MySQL (apache#856)
* support COPY INTO in snowflake (apache#841)
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
* Add `dialect_from_str` and improve `Dialect` documentation (apache#848)
* Add `dialect_from_str` and improve `Dialect` documentation
* cleanup
* fix compilation with nostd
* Support multiple-table DELETE syntax (apache#855)
* Support `DISTINCT ON (...)` (apache#852)
* Support "DISTINCT ON (...)"
* a test
* fix the merge
* Test trailing commas (apache#859)
* test: add tests for trailing commas
* tweaks
* Add support for query source in COPY .. TO statement (apache#858)
* Add support for query source in COPY .. TO statement
* Fix compile error
* Fix logical merge conflict (apache#865)
* Fix tiny typo in custom_sql_parser.md (apache#864)
* Make Expr::Interval its own struct (apache#872)
* Make Expr::Interval its own struct
* Add test interval display
* Fix cargo fmt
* Include license file in published crate (apache#871)
* Add support for multiple expressions, order by in aggregations (apache#879)
* Add support for multiple expressions, order by in aggregations
* Fix formatting errors
* Resolve linter errors
* Add parse_multipart_identifier function to parser (apache#860)
* Add parse_multipart_identifier function to parser
* Update doc for parse_multipart_identifier
* Fix conflict
* feat: Add custom operator (apache#868)
* feat: Add custom operator
From apache#863
- It doesn't parse anything — I'm not sure how to parse ` SELECT 'a' REGEXP '^[a-d]';` with `REGEXP` as the operator... (but fine for my narrow purpose)
- If we need tests, where would I add them?
* Update src/ast/operator.rs
---------
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
* feat: Support MySQL's `DIV` operator (apache#876)
* feat: MySQL's DIV operator
* fix: do not use `_` prefix for used variable
---------
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
* truncate: table as optional keyword (apache#883)
Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
* feat: add DuckDB dialect (apache#878)
* feat: add DuckDB dialect
* formatting
* fix conflict
* support // in GenericDialect
* add DucDbDialect to all_dialects
* add comment from suggestion
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
* fix: support // in GenericDialect
---------
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
* Add support for first, last aggregate function parsing (apache#882)
* Add order by parsing to functions
* Fix doc error
* minor changes
* Named window frames (apache#881)
* after over clause, named window can be parsed with window ... as after having clause
* Lint errors are fixed
* Support for multiple windows
* fix lint errors
* simplifications
* rename function
* Rewrite named window search in functional style
* Test added and some minor changes
* Minor changes on tests and namings, and semantic check is removed
---------
Co-authored-by: Mustafa Akur <mustafa.akur@synnada.ai>
Co-authored-by: Mehmet Ozan Kabak <ozankabak@gmail.com>
* Fix merge conflict (apache#885)
* Update CHANGELOG for `0.34.0` release (apache#884)
* chore: Release sqlparser version 0.34.0
* Update criterion requirement from 0.4 to 0.5 in /sqlparser_bench (apache#890)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
---------
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: AviRaboah <91826424+AviRaboah@users.noreply.github.com>
Co-authored-by: pawel.leszczynski <leszczynski.pawel@gmail.com>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Co-authored-by: Aljaž Mur Eržen <aljazerzen@users.noreply.github.com>
Co-authored-by: Armin Primadi <aprimadi@gmail.com>
Co-authored-by: Okue <nogideca@gmail.com>
Co-authored-by: Andrew Kane <acekane1@gmail.com>
Co-authored-by: Mustafa Akur <106137913+mustafasrepo@users.noreply.github.com>
Co-authored-by: Jeffrey <22608443+Jefffrey@users.noreply.github.com>
Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
Co-authored-by: eitsupi <50911393+eitsupi@users.noreply.github.com>
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Co-authored-by: Berkay Şahin <124376117+berkaysynnada@users.noreply.github.com>
Co-authored-by: Mustafa Akur <mustafa.akur@synnada.ai>
Co-authored-by: Mehmet Ozan Kabak <ozankabak@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alambalambalamb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add DuckDB's integer devision operator //

3 participants

@eitsupi@alamb@coveralls