Uh oh!
There was an error while loading. Please reload this page.
Support bigquery CAST AS x [STRING|DATE] FORMAT syntax - #978
Merged
Conversation
lustefaniakforce-pushed
the
cast-format
branch
2 times, most recently
from
September 25, 2023 15:50
0d42a8a to
c274bcdComparealamb
reviewed
Oct 5, 2023
Contributor
There was a problem hiding this comment.
Thank you @lustefaniak -- sorry I missed this one in the sea of reiviews. I think it is looking good in my mind -- I have some suggestions -- let me know what you think
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
alamb
commented
Oct 5, 2023
Contributor
I think the CI failures are not related to the changes in this PR -- if you merge up / rebase from main they should be solved. See #995 |
lustefaniakforce-pushed
the
cast-format
branch
2 times, most recently
from
October 20, 2023 09:01
ebe32db to
00bd9f3CompareCAST AS x FORMAT syntaxCAST AS x FORMAT syntaxCAST AS x [STRING|DATE] FORMAT syntaxalamb
approved these changes
Oct 20, 2023
alamb
left a comment
Contributor
There was a problem hiding this comment.
Looks great -- thank you @lustefaniak
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://cloud.google.com/bigquery/docs/reference/standard-sql/conversion_functions#cast_as_date