Skip to content

sqllogictest handles decimals inconsistently #23160

Description

@AdamGS

As far as I can tell, decimal in the SLT suite are currently handled in the following way:

  1. The two larger variants (128 and 256 bits) are handled as floats ('R' column type), and have their own formatter through the DecimalType type and BigDecimal that has set display accuracy (12 digits).
  2. Smaller decimal types (32 and 64 bits) are handled as "unknown" ('?' column type) and use the fallback formatter.

This makes tests less accurate and causes inconsistencies between different code paths.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions