Skip to content

Clippy failing on master #4100

Description

@alamb

Describe the bug
CI clippy checks are failing

https://github.com/apache/arrow-datafusion/actions/runs/3386593123/jobs/5626537564

 Compiling datafusion-proto v13.0.0 (/__w/arrow-datafusion/arrow-datafusion/datafusion/proto)
error: deref which would be done by auto-deref
--> datafusion/proto/build.rs:51:17
|
51 | .expect(&*format!("Cannot read {:?}", &descriptor_path));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&format!("Cannot read {:?}", &descriptor_path)`
|
= note: `-D clippy::explicit-auto-deref` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
error: deref which would be done by auto-deref
--> datafusion/proto/build.rs:55:17
|
55 | .expect(&*format!(
| _________________^
56 | | "Cannot register descriptors {:?}",
57 | | &descriptor_set
58 | | ))
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
help: try this
|
55 ~ .expect(&format!(
56 + "Cannot register descriptors {:?}",
57 + &descriptor_set
58 ~ ))
|

To Reproduce
run rustup update and then cargo clippy

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Rust 1.65 was released https://blog.rust-lang.org/2022/11/03/Rust-1.65.0.html

https://github.com/rust-lang/rust-clippy/blob/master/CHANGELOG.md#rust-165

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions