Uh oh!
There was an error while loading. Please reload this page.
cleanup(tests): Move tests from push_down_projections.rs to optimize_projections.rs - #10071
Merged
alamb merged 4 commits intoApr 15, 2024
Merged
Conversation
kavirajk
marked this pull request as draft
April 13, 2024 21:26
alamb
commented
Apr 13, 2024
Contributor
Thank you @kavirajk 🙏 ! |
…ze_projections.rs` Fixes: apache#9978 The PR apache#8340 removed `push_down_projections.rs` in favour of `optimize_projections.rs`. This PR moves the tests as well. Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
kavirajkforce-pushed
the
kavirajk/migrate-push-down-projection-tests
branch
from
April 14, 2024 13:29
50c449d to
ba36340CompareSigned-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
kavirajk
marked this pull request as ready for review
April 14, 2024 13:39
alamb
approved these changes
Apr 15, 2024
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thank you @kavirajk -- this is a very nice first contribution. 🧹 ✅
FYI @mustafasrepo and @jackwener
alamb
commented
Apr 15, 2024
Contributor
Thanks again @kavirajk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes#9978
Rationale for this change
The PR #8340 removed
push_down_projections.rsin favour ofoptimize_projections.rs. This PR moves the tests as well.What changes are included in this PR?
Moving tests. No other changes.
Are these changes tested?
Yes
Are there any user-facing changes?
No