Skip to content

Clarify docs explaining the relationship between SessionState and SessionContext - #10350

Merged
comphead merged 2 commits into
apache:mainfrom
alamb:alamb/session_state_docs
May 3, 2024
Merged

Clarify docs explaining the relationship between SessionState and SessionContext#10350
comphead merged 2 commits into
apache:mainfrom
alamb:alamb/session_state_docs

Conversation

@alamb

@alambalamb commented May 2, 2024

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Part of #7013

Rationale for this change

As @westonpace explained in #10330 (comment) the relationship and differences between these classes is not clear.

What changes are included in this PR?

Try to clarify the differences and when people should create one or the other

Are these changes tested?

CI doc checks

Are there any user-facing changes?

Just docs, no change in functionality

@alambalamb added the documentation Improvements or additions to documentation label May 2, 2024
@github-actionsgithub-actionsBot added core Core DataFusion crate and removed documentation Improvements or additions to documentation labels May 2, 2024
@alamb

alamb commented May 2, 2024

Copy link
Copy Markdown
ContributorAuthor

CI failed due to #10352

@westonpacewestonpace left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this helps my understanding a lot!

@alambalamb added the documentation Improvements or additions to documentation label May 3, 2024

@compheadcomphead left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @alamb lgtm

@comphead
comphead merged commit 2c56a3c into apache:mainMay 3, 2024
@alamb
alamb deleted the alamb/session_state_docs branch May 3, 2024 16:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coreCore DataFusion cratedocumentationImprovements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alamb@westonpace@comphead