Uh oh!
There was an error while loading. Please reload this page.
Add more sqllogictests for parquet_sorted_statistics - #10381
Conversation
yyy1000
commented
May 4, 2024
I think it's better to push this though not finished to get early comments to better modify the code. 😀 |
alamb
commented
May 5, 2024
I agree -- thank you @yyy1000 -- I changed the description to reflect this |
parquet_sorted_statsiticsparquet_sorted_statsiticsparquet_sorted_statisticsalamb
commented
May 5, 2024
| WITH ORDER (a ASC NULLS LAST) | ||
| LOCATION 'test_files/scratch/parquet_sorted_statistics/test_table1'; | ||
| query TT |
There was a problem hiding this comment.
thanks @yyy1000 would you mind adding the description what exactly it tests, what is so outstanding in the output we looking for?
There was a problem hiding this comment.
Sure, the test is mainly from #9593 (comment), I think it will test the case when schema and query order to verify sort preserving merge would not be used.
Will add the description soon.
comphead
left a comment
There was a problem hiding this comment.
I like it, but I'd say the test looks slightly confusing me as its not very clear what exactly the test is asserting, would be nice to have the test description
Which issue does this PR close?
Part of #10336 .
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?