Skip to content

Minor: improve Expr documentation - #10685

Merged
jonahgao merged 5 commits into
apache:mainfrom
alamb:alamb/expr_docs
May 29, 2024
Merged

Minor: improve Expr documentation#10685
jonahgao merged 5 commits into
apache:mainfrom
alamb:alamb/expr_docs

Conversation

@alamb

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Part of #7013

Rationale for this change

I was preparing to add some examples of TreeNode APIs and I noticed several places to improve Expr APIs

What changes are included in this PR?

Improve docstrings and examples

Are these changes tested?

By CI

Are there any user-facing changes?

Only doc changes, no functional changes

@alambalamb added the documentation Improvements or additions to documentation label May 27, 2024
@alamb
alamb marked this pull request as ready for review May 27, 2024 10:11
@github-actionsgithub-actionsBot added sql SQL Planner logical-expr Logical plan and expressions and removed documentation Improvements or additions to documentation labels May 27, 2024
@alamb
alamb marked this pull request as draft May 27, 2024 10:12
@alamb
alambforce-pushed the alamb/expr_docs branch 2 times, most recently from 2ec8f11 to a0811d8CompareMay 27, 2024 10:21
@alamb
alamb marked this pull request as ready for review May 27, 2024 11:11
@alambalamb added the documentation Improvements or additions to documentation label May 27, 2024
Comment threaddatafusion/expr/src/expr.rs

@compheadcomphead left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb

@github-actionsgithub-actionsBot removed the documentation Improvements or additions to documentation label May 29, 2024
@jonahgao
jonahgao merged commit 0905426 into apache:mainMay 29, 2024
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
* Minor: improve Expr documentation
* Update datafusion/expr/src/expr.rs
Co-authored-by: Oleks V <comphead@users.noreply.github.com>
* Refine words
---------
Co-authored-by: Oleks V <comphead@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

logical-exprLogical plan and expressionssqlSQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alamb@comphead@jonahgao