Uh oh!
There was an error while loading. Please reload this page.
Add to_local_time() in function reference docs - #11401
Merged
Merged
Conversation
alamb
approved these changes
Jul 10, 2024
alamb
left a comment
Contributor
There was a problem hiding this comment.
Looks great -- thank you @appletreeisyellow
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
to_local_time() in documentto_local_time() in function referencealamb
commented
Jul 10, 2024
Contributor
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
to_local_time() in function referenceto_local_time() in function reference docsalamb
commented
Jul 11, 2024
Contributor
Thanks again @appletreeisyellow ! |
Lordworms pushed a commit
to Lordworms/arrow-datafusion
that referenced
this pull request
Jul 12, 2024
* chore: add document for `to_local_time()` * chore: feedback Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
findepi pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* chore: add document for `to_local_time()` * chore: feedback Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
xinlifoobar pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jul 17, 2024
* chore: add document for `to_local_time()` * chore: feedback Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
xinlifoobar pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jul 18, 2024
* chore: add document for `to_local_time()` * chore: feedback Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow-up PR for #11347 (comment)
Relates to #10602, #11358
Rationale for this change
A scalar UDF
to_local_time()was added in #11347. This PR documentsto_local_time()in the scalar function reference page.What changes are included in this PR?
After adding the document for
to_local_time(), the doc page will look like this:Are these changes tested?
No. Only adding documents, so it shouldn't break anything.
Are there any user-facing changes?
No