Uh oh!
There was an error while loading. Please reload this page.
Feature/alternate function extension - #11582
Closed
timsaucer wants to merge 6 commits into
Closed
Conversation
…ttings for window functions
…guments. Other parameters will be set via the ExprFuncBuilder
…e cleanliness and not strictly required
…g ExprFunctionExt trait so we can guarantee a consistent user experience no matter which they call on the Expr and which on the builder
jayzhan211
commented
Jul 22, 2024
Contributor
I had tried to directly modify |
timsaucer
commented
Jul 22, 2024
MemberAuthor
Closing in favor of #11550 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternate approach to #11550
After we discuss, I will update the PR description if necessary. See the other PR for context.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?