Uh oh!
There was an error while loading. Please reload this page.
test: re-enable window function over parquet with forced collisions - #11939
Conversation
alamb
commented
Aug 12, 2024
I re-ran the relevant test: cargo test --test sqllogictests --features=force_hash_collisions -- parquetAnd indeed it passes locally for me too |
| # FIXME(#TODO) fails with feature `force_hash_collisions` | ||
| # https://github.com/apache/datafusion/issues/11660 | ||
| # Perform the query: |
There was a problem hiding this comment.
| # Perform the query: |
There was a problem hiding this comment.
Would be great to add some comments why test is so specific
There was a problem hiding this comment.
I agree better comments would be nice -- however I don't think this PR makes the comment any more/less cryptic, so I don't think we should hold it for better comments.
Maybe we can improve the comments as a future PR
| # FIXME(#TODO) fails with feature `force_hash_collisions` | ||
| # https://github.com/apache/datafusion/issues/11660 | ||
| # Perform the query: |
There was a problem hiding this comment.
I agree better comments would be nice -- however I don't think this PR makes the comment any more/less cryptic, so I don't think we should hold it for better comments.
Maybe we can improve the comments as a future PR
Which issue does this PR close?
Closes#11660.
Rationale for this change
After several attempts to reproduce the failure locally and in fork CI it still was not reproducing. Also I wasn't able to find any workflow failure related to 1.80 upgrade in PRs and on main. So, trying to just uncomment the test.
What changes are included in this PR?
Test uncommented.
Are these changes tested?
Are there any user-facing changes?