Skip to content

Allow adding issues. - #12

Merged
alamb merged 1 commit into
apache:masterfrom
jorgecarleitao:allow_issues
Apr 20, 2021
Merged

Allow adding issues.#12
alamb merged 1 commit into
apache:masterfrom
jorgecarleitao:allow_issues

Conversation

@jorgecarleitao

Copy link
Copy Markdown
Member

Also removed contributing, as that requires a re-write.

Problem: currently we cannot add issues; only questions.

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@codecov-commenter

codecov-commenter commented Apr 19, 2021

Copy link
Copy Markdown

Codecov Report

Merging #12 (e5e430e) into master (4123600) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #12 +/- ##
=======================================
Coverage 70.41% 70.41% =======================================
Files 123 123 Lines 21261 21261 =======================================
Hits 14970 14970 Misses 6291 6291 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4123600...e5e430e. Read the comment docs.

@alamb

Copy link
Copy Markdown
Contributor

I rewrote master to remove the history of the other languages (and 50MB of history). This means this PR will need to be "rebased" against the current master.

The best way I found to do this was to find the relevant commits (via git log) and then cherry-pick them one at a time. For example (change COMMIT-SHA to whatever the commit actually is):

git reset --hard apache/master
git cherry-pick COMMIT-SHA
git push -f your_rep

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

786eaf4 loos good

@alamb

Copy link
Copy Markdown
Contributor

I am going to try and rebase this PR

Also removed contributing, as that requires a re-write.
@alamb
alamb merged commit c365a4f into apache:masterApr 20, 2021
@houqphouqp added the development-process Related to development process of DataFusion label Jul 29, 2021
andygrove added a commit that referenced this pull request Jan 12, 2023
* Initial commit
* initial commit
* failing test
* table scan projection
* closer
* test passes, with some hacks
* use DataFrame (#2)
* update README
* update dependency
* code cleanup (#3)
* Add support for Filter operator and BinaryOp expressions (#4)
* GitHub action (#5)
* Split code into producer and consumer modules (#6)
* Support more functions and scalar types (#7)
* Use substrait 0.1 and datafusion 8.0 (#8)
* use substrait 0.1
* use datafusion 8.0
* update datafusion to 10.0 and substrait to 0.2 (#11)
* Add basic join support (#12)
* Added fetch support (#23)
Added fetch to consumer
Added limit to producer
Added unit tests for limit
Added roundtrip_fill_none() for testing when None input can be converted to 0
Update src/consumer.rs
Co-authored-by: Andy Grove <andygrove73@gmail.com>
Co-authored-by: Andy Grove <andygrove73@gmail.com>
* Upgrade to DataFusion 13.0.0 (#25)
* Add sort consumer and producer (#24)
Add consumer
Add producer and test
Modified error string
* Add serializer/deserializer (#26)
* Add plan and function extension support (#27)
* Add plan and function extension support
* Removed unwraps
* Implement GROUP BY (#28)
* Add consumer, producer and tests for aggregate relation
Change function extension registration from absolute to relative anchor
(reference)
Remove operator to/from reference
* Fixed function registration bug
* Add test
* Addressed PR comments
* Changed field reference from mask to direct reference (#29)
* Changed field reference from masked reference to direct reference
* Handle unsupported case (struct with child)
* Handle SubqueryAlias (#30)
Fixed aggregate function register bug
* Add support for SELECT DISTINCT (#31)
Add test case
* Implement BETWEEN (#32)
* Add case (#33)
* Implement CASE WHEN
* Add more case to test
* Addressed comments
* feat: support explicit catalog/schema names in ReadRel (#34)
* feat: support explicit catalog/schema names in ReadRel
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
* fix: use re-exported expr crate
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
* move files to subfolder
* RAT
* remove rust.yaml
* revert .gitignore changes
* tomlfmt
* tomlfmt
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Co-authored-by: Daniël Heres <danielheres@gmail.com>
Co-authored-by: JanKaul <jankaul@mailbox.org>
Co-authored-by: nseekhao <37189615+nseekhao@users.noreply.github.com>
Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
alamb pushed a commit that referenced this pull request Jul 17, 2024
* Add dialect param to use CHAR instead of TEXT for Utf8 unparsing for MySQL (#12)
* Configurable data type instead of flag for Utf8 unparsing
* Fix type in comment
xinlifoobar pushed a commit to xinlifoobar/datafusion that referenced this pull request Jul 17, 2024
* Add dialect param to use CHAR instead of TEXT for Utf8 unparsing for MySQL (apache#12)
* Configurable data type instead of flag for Utf8 unparsing
* Fix type in comment
xinlifoobar pushed a commit to xinlifoobar/datafusion that referenced this pull request Jul 18, 2024
* Add dialect param to use CHAR instead of TEXT for Utf8 unparsing for MySQL (apache#12)
* Configurable data type instead of flag for Utf8 unparsing
* Fix type in comment
Lordworms pushed a commit to Lordworms/arrow-datafusion that referenced this pull request Jul 23, 2024
* Add dialect param to use CHAR instead of TEXT for Utf8 unparsing for MySQL (apache#12)
* Configurable data type instead of flag for Utf8 unparsing
* Fix type in comment
loloxwg pushed a commit to loloxwg/datafusion that referenced this pull request Dec 9, 2024
filter projection change to merge projection
jcsherin pushed a commit to jcsherin/datafusion that referenced this pull request Nov 18, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-processRelated to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jorgecarleitao@codecov-commenter@alamb@houqp