Uh oh!
There was an error while loading. Please reload this page.
Support skewness(x) in Aggregation function - #12295
Conversation
|
2010YOUY01
commented
Sep 3, 2024
I think we can port tests from duckdb https://github.com/duckdb/duckdb/blob/main/test/sql/aggregate/aggregates/test_skewness.test |
| skewness(expression) | ||
| ``` | ||
| #### Arguments |
There was a problem hiding this comment.
I just realized we dont have any examples in aggregate_functions.ms
comphead
commented
Sep 4, 2024
Basically I'm feeling we have too much of user .md files, duplicating the functions description and poorly connected to each other which confuses a lot. @alamb WDYT about having a single file for all SQL functions/scalars/expressions like in https://spark.apache.org/docs/latest/api/sql/index.html with description, examples Btw Spark holds an internal meta repository that allows such doc to be regenerated from the code, which can be next step |
alamb
commented
Sep 5, 2024
I agree What I actually think would be ideal is exactly as @comphead describes and put all the documentation about the functions in the code, and then have a post processing step that auto generates the documentation This is how the configuration setting documentation is created. Here is the script that does it: BTW I think this is the direction @findepi is heading with #12266. I also think GlareDB did something similar, but I can't find the link now. |
alamb
commented
Sep 5, 2024
I also wonder if we should consider where to draw the line on features to include (i.e. should we include |
alamb
commented
Sep 23, 2024
Perhaps we can port this function to https://github.com/datafusion-contrib/datafusion-functions-extra as well now that @dmitrybugakov has started that project |
dharanad
commented
Sep 27, 2024
Closing this PR. Will move this to https://github.com/datafusion-contrib/datafusion-functions-extra as suggested |
Which issue does this PR close?
Part of #12254
Closes#12249
Implemented by referring to https://github.com/duckdb/duckdb/blob/main/src/core_functions/aggregate/distributive/skew.cpp
Rationale for this change
What changes are included in this PR?
Added
skewnessUDAF.Ref: https://duckdb.org/docs/sql/functions/aggregates#skewnessx
Are these changes tested?
Are there any user-facing changes?