Skip to content

Move TopKAggregation rule into physical-optimizer crate - #12334

Merged
alamb merged 5 commits into
apache:mainfrom
lewiszlw:move-TopKAggregation
Sep 6, 2024
Merged

Move TopKAggregation rule into physical-optimizer crate#12334
alamb merged 5 commits into
apache:mainfrom
lewiszlw:move-TopKAggregation

Conversation

@lewiszlw

Copy link
Copy Markdown
Member

Which issue does this PR close?

part of #11502.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actionsgithub-actionsBot added optimizer Optimizer rules core Core DataFusion crate labels Sep 5, 2024
Comment threaddatafusion-cli/Cargo.toml Outdated

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lewiszlw -- other than the MSRV change this looks great to me 🙏

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goo to me -- thank you @lewiszlw

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coreCore DataFusion crateoptimizerOptimizer rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@lewiszlw@alamb