Uh oh!
There was an error while loading. Please reload this page.
Rename aggregation modules, GroupColumn - #12619
Merged
Merged
Conversation
jayzhan211
commented
Sep 25, 2024
Contributor
Since the change is not released, I think there is no API change |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #12269 from @jayzhan211
Rationale for this change
As I was reviewing the code, the names of the modules don't quite match their contents and aren't consistent with
row.rs, so I would like to fix that as we begin to work on this code moreChanges:
What changes are included in this PR?
ArrowRowEqtoGroupColumnas I think that better reflects what the trait doesAre these changes tested?
CI tests
Are there any user-facing changes?