Skip to content

Minor: Add github link to code that was upstreamed - #12660

Merged
alamb merged 1 commit into
apache:mainfrom
alamb:alamb/take_docs
Sep 29, 2024
Merged

Minor: Add github link to code that was upstreamed#12660
alamb merged 1 commit into
apache:mainfrom
alamb:alamb/take_docs

Conversation

@alamb

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Follow on to #12654

Rationale for this change

@mustafasrepo ported take_arrays upstream to arrow-rs in apache/arrow-rs#6475

Let's leave a link to that so our future selves know we can remove the copy in DataFusion

What changes are included in this PR?

Add a doc link

Are these changes tested?

Are there any user-facing changes?

@github-actionsgithub-actionsBot added the common Related to common crate label Sep 28, 2024

@jonahgaojonahgao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb
alamb merged commit 810e908 into apache:mainSep 29, 2024
@alamb

Copy link
Copy Markdown
ContributorAuthor

Thanks @jonahgao

@alamb
alamb deleted the alamb/take_docs branch September 29, 2024 09:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commonRelated to common crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alamb@jonahgao