Uh oh!
There was an error while loading. Please reload this page.
Improve AggregationFuzzer error reporting - #12832
Conversation
| impl AggregationFuzzTestTask { | ||
| async fn run(&self) { | ||
| async fn run(&self) -> Result<()> { |
There was a problem hiding this comment.
the key change is to return an actual DataFusionError here and then print it when looking at the task output
Uh oh!
There was an error while loading. Please reload this page.
| ### Sql:\n{}\n\ | ||
| ### Schema:\n{}\n\ | ||
| ### Session context params:\n{:?}\n\ |
There was a problem hiding this comment.
Maybe we will also care about some information about reproducing like session context params, sql, when we encounter inconsistent results?
There was a problem hiding this comment.
I think that information is already included when inconsistent results are detected (in check_result) but perhaps I don't understand what you are proposing here
There was a problem hiding this comment.
Oh, it is my mistake, I see it now.
alamb
commented
Oct 11, 2024
THanks @Rachelint -- I am now just waiting for another committer to approve this PR so I can merge it |
alamb
commented
Oct 15, 2024
Thank you @jonahgao |
Which issue does this PR close?
Part of #12114
Rationale for this change
@Rachelint added an amazing fuzzer framework in #12667 that actually found bugs already ❤️
However, the messages when it fails are hard to interpret
What changes are included in this PR?
DataFusionErrors and printing them rather thanunwraping in a taskAre these changes tested?
I tested manually
Error before this PR:
Error after this PR:
Are there any user-facing changes?