Skip to content

Backport "physical-plan: Cast nested group values back to dictionary if necessary" (#12586) - #12976

Merged
alamb merged 1 commit into
apache:branch-42from
matthewmturner:patch/12586
Oct 16, 2024
Merged

Backport "physical-plan: Cast nested group values back to dictionary if necessary" (#12586)#12976
alamb merged 1 commit into
apache:branch-42from
matthewmturner:patch/12586

Conversation

@matthewmturner

@matthewmturnermatthewmturner commented Oct 16, 2024

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Part of #12813 applies fix from #12586 / #12542

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actionsgithub-actionsBot added the physical-expr Changes to the physical-expr crates label Oct 16, 2024
@XuanwoXuanwo mentioned this pull request Oct 16, 2024
4 tasks
@matthewmturnermatthewmturner changed the title Patch for PR 12586Backport "physical-plan: Cast nested group values back to dictionary if necessary" from #12586Oct 16, 2024
@matthewmturnermatthewmturner changed the title Backport "physical-plan: Cast nested group values back to dictionary if necessary" from #12586Backport "physical-plan: Cast nested group values back to dictionary if necessary" (#12586)Oct 16, 2024
@matthewmturner

Copy link
Copy Markdown
ContributorAuthor

@alamb@Xuanwo FYI

@XuanwoXuanwo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, no conflict. Let's wait CI to be green.

@alamb

Copy link
Copy Markdown
Contributor

close/reopen to trigger CI

@alambalamb closed this Oct 16, 2024
@alambalamb reopened this Oct 16, 2024
@matthewmturner

Copy link
Copy Markdown
ContributorAuthor

@alamb FYI i think this is good to go

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alamb
alamb merged commit 7fbc134 into apache:branch-42Oct 16, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-exprChanges to the physical-expr crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@matthewmturner@alamb@Xuanwo