Uh oh!
There was an error while loading. Please reload this page.
Backport config option skip_physical_aggregate_schema_check #13176 to 42 - #13189
Merged
Conversation
* Add option to skip physical aggregate check * tweak wording * update test
alamb
marked this pull request as ready for review
October 30, 2024 18:40
comphead
approved these changes
Oct 30, 2024
alamb
commented
Oct 30, 2024
ContributorAuthor
Thank you @comphead -- I will move on to preparing the release now |
Dandandan pushed a commit
to coralogix/arrow-datafusion
that referenced
this pull request
Feb 11, 2025
…13176 to 42 (apache#13189) * Add config option `skip_physical_aggregate_schema_check ` (apache#13176) * Add option to skip physical aggregate check * tweak wording * update test * Change default value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of
Physical input schema should be the same as the one converted from logical schemaerror #13065Rationale for this change
By backporting this option (disabled) I hope we can upblock other upgrades
What changes are included in this PR?
This PR backports #13176 to the 42 branch to fix the issue with the physical aggregate schema check.
Note unlike the original PR, the default value is
true(the PR defaults to disabling the check)Are these changes tested?
By CI
Are there any user-facing changes?
A newly added check in 42 is now disabled by default