Uh oh!
There was an error while loading. Please reload this page.
Remove BuiltInWindowFunction (LogicalPlans) - #13393
Merged
Merged
Conversation
alamb
marked this pull request as draft
November 13, 2024 15:57
alamb
commented
Nov 13, 2024
ContributorAuthor
There are actually several related "BuiltInWindowExpr" in physical-expr that need to be cleaned up as well (that are no longer related to BuiltInWindowExprs). We may also be able to remove a level of trait. |
alambforce-pushed
the
alamb/remove_built_in_window
branch
from
November 13, 2024 16:58
e6bb4c5 to
a300ee5CompareBuiltInWindowFunctionBuiltInWindowFunction (LogicalPlans)jonathanc-n
commented
Nov 13, 2024
Contributor
@alamb@buraksenn@Omega359 Pretty sure we can now clean up the old window docs, due to the nth_value migration being merged. Lemme see if I can do that really quick |
alamb
commented
Nov 13, 2024
ContributorAuthor
Yes, we can -- I think that is tracked by |
alamb
marked this pull request as ready for review
November 14, 2024 07:06
| /// | ||
| /// In SQL, you can use: | ||
| /// - Actual window functions ([`WindowUDF`]) | ||
| /// - Noraml aggregate functions ([`AggregateUDF`]) |
jcsherin
commented
Nov 14, 2024
Contributor
LGTM 👍. Thanks @alamb |
alamb
commented
Nov 14, 2024
| /// Logical representation of a user-defined window function (UDWF) | ||
| /// A UDWF is different from a UDF in that it is stateful across batches. | ||
| /// Logical representation of a user-defined window function (UDWF). |
ContributorAuthor
There was a problem hiding this comment.
I also threw in some drive by documentation improvements to sweeten the deal 🍯
| aggregate, | ||
| ) | ||
| } | ||
| // TODO: Ordering not supported for Window UDFs yet |
ContributorAuthor
There was a problem hiding this comment.
ORDER BY is already supported as the order_by clause is passed to window_expr_from_aggregate_expr
| /// | ||
| /// In SQL, you can use: | ||
| /// - Actual window functions ([`WindowUDF`]) | ||
| /// - Noraml aggregate functions ([`AggregateUDF`]) |
alamb
commented
Nov 15, 2024
ContributorAuthor
Thanks @crepererum and @jcsherin for the reviews |
avantgardnerio pushed a commit
to coralogix/arrow-datafusion
that referenced
this pull request
Sep 23, 2025
* Remove BuiltInWindowFunction * fix docs * Fix typo (cherry picked from commit 75a27a8)
avantgardnerio pushed a commit
to coralogix/arrow-datafusion
that referenced
this pull request
Oct 2, 2025
* Remove BuiltInWindowFunction * fix docs * Fix typo (cherry picked from commit 75a27a8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
WindowFunctionInterface (remove built in list ofBuiltInWindowFunctions) #8709 🎉!!!nth_valuebuiltIn function to User Defined Window Function #13201Rationale for this change
@buraksen and @jcsherin ported the last window function over, so now we can remove the old BuiltInWindowFunction code
This was so tempting a cleanup that I had to give it a try (and I wanted to do some coding)
What changes are included in this PR?
Changes:
BuiltInWindowFunctionBuiltInWindowFunctionDefinition::BuiltInWindowFunctionAre these changes tested?
Yes, by existing CI