Skip to content

chore: Remove window_functions_new docs - #13395

Merged
comphead merged 1 commit into
apache:mainfrom
jonathanc-n:update-window-functions-docs
Nov 13, 2024
Merged

chore: Remove window_functions_new docs#13395
comphead merged 1 commit into
apache:mainfrom
jonathanc-n:update-window-functions-docs

Conversation

@jonathanc-n

@jonathanc-njonathanc-n commented Nov 13, 2024•
edited by alamb
Loading

Copy link
Copy Markdown
Contributor

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation development-process Related to development process of DataFusion labels Nov 13, 2024
@jonathanc-n

jonathanc-n commented Nov 13, 2024

Copy link
Copy Markdown
ContributorAuthor

For the future, should we be adding sql examples for the window functions?

@alamb

alamb commented Nov 13, 2024

Copy link
Copy Markdown
Contributor

For the future, should we be adding sql examples for the window functions?

Yes that would be awesome -- any chance you could file a ticket to track doing so? In case it helps, here is a PR with an example of how to do: #13390

alamb
alamb approved these changes Nov 13, 2024
View reviewed changes

@alambalamb left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding -- thank you @jonathanc-n

FYI @Omega359 -- the project is finally done!

@jonathanc-njonathanc-n mentioned this pull request Nov 13, 2024
Closed
@comphead
comphead merged commit 8a88fdc into apache:mainNov 13, 2024
@Omega359

Omega359 commented Nov 13, 2024

Copy link
Copy Markdown
Contributor

WOOT! I'm glad we were able to get this functionality into DF - I think it'll be better for it!

@alamb

alamb commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

WOOT! I'm glad we were able to get this functionality into DF - I think it'll be better for it!

100% -- it was also really cool to see so many people involved. Talk about a community effort!

@jonathanc-n
jonathanc-n deleted the update-window-functions-docs branch November 27, 2024 22:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alambalambalamb approved these changes

Assignees

No one assigned

Labels

development-processRelated to development process of DataFusiondocumentationImprovements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove old static Window Functions page [EPIC] Automatically generate all function documentation from code

4 participants

@jonathanc-n@alamb@Omega359@comphead