Uh oh!
There was an error while loading. Please reload this page.
WIP: Update sqlparser to next release - #13546
Closed
alamb wants to merge 2 commits into
Closed
Conversation
alamb
marked this pull request as draft
November 24, 2024 12:52
This was referenced Nov 24, 2024
Merged
alamb
commented
Nov 26, 2024
ContributorAuthor
I believe the SHOW COLUMNs test is failing due to this find by @goldmedal |
alambforce-pushed
the
alamb/sqlparser_with_span
branch
from
November 29, 2024 12:23
038047c to
38a8e4eComparealambforce-pushed
the
alamb/sqlparser_with_span
branch
from
November 30, 2024 13:22
38a8e4e to
3545647Comparealambforce-pushed
the
alamb/sqlparser_with_span
branch
2 times, most recently
from
December 4, 2024 15:51
14e50a1 to
9b9df23Comparealambforce-pushed
the
alamb/sqlparser_with_span
branch
from
December 6, 2024 20:43
8bf418d to
52c5d17Compare
Closed
5 tasks
alamb
commented
Dec 13, 2024
ContributorAuthor
Superceded by #13767 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Spannedto retrieve source locations on AST nodes datafusion-sqlparser-rs#1435Rationale for this change
This PR demonstrates what is needed to update DataFusion to the next version of sqlparser-rs including new span information in sqlparser-rs
Also, help test to ensure that the next sqlparser-rs release has no regressions by testing with DataFusion before we release it
What changes are included in this PR?
Pin to a pre-release version of sqlparser-rs and update DataFusion
SHOW TABLE/SHOW COLUMNSwhich is entirely unrelated to the span thing (fixed by @goldmedal in Support relation visitor to visit theOptionfield datafusion-sqlparser-rs#1556)Are these changes tested?
Yes, by existing unit tests
Are there any user-facing changes?