Uh oh!
There was an error while loading. Please reload this page.
chore: reinstate find_df_window_func - #13708
Conversation
| } | ||
| /// Find DataFusion's built-in window function by name. | ||
| #[deprecated(since = "44.0.0", note = "built-in window functions have been removed")] |
There was a problem hiding this comment.
Shall we give a hint about the best replacement API?
There was a problem hiding this comment.
I'll have to research what the replacement API is first, but yes, that would be good. Once I have Comet tests passing, I will come back and improve this.
| pub fn find_df_window_func(_name: &str) -> Option<WindowFunctionDefinition> { | ||
| None |
There was a problem hiding this comment.
As someone who did upgrades, I'd appreciate a compiler error more than a dummy implementation.
But we can do good here. We can see what's the name being looked up and return non-built-in implementation based on that. The return type allows to do this, fortunately.
There was a problem hiding this comment.
That makes sense. I am moving this to draft until I can implement the feedback.
Which issue does this PR close?
Related to #13702
Rationale for this change
Public API function
find_df_window_funcwas removed in #13201. It would be better to deprecate it and remove it in a future release.What changes are included in this PR?
Add deprecated method.
Are these changes tested?
Are there any user-facing changes?