Uh oh!
There was an error while loading. Please reload this page.
Remove dependency on physical-optimizer on functions-aggregates - #14134
Merged
Conversation
alambforce-pushed
the
alamb/remove_dependency
branch
from
January 16, 2025 15:20
c1ed7a0 to
d2bab2bComparealamb
marked this pull request as ready for review
January 16, 2025 15:29
alamb
commented
Jan 17, 2025
ContributorAuthor
Thank you for the review @jonahgao 🙏 |
alamb
commented
Jan 17, 2025
| Ok(DataType::Int64) | ||
| } | ||
| fn is_nullable(&self) -> bool { |
ContributorAuthor
There was a problem hiding this comment.
BTW this makes the count function stub match the actual count function which is also not nullable
This was required to get the existing tests to pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft it is based on #14083 from @mnpwWhich issue does this PR close?
This is a follow up to
SanityCheckerintophysical-optimizercrate #14083 from @mnpwRationale for this change
We are trying to make sure
datafusion-physical-optimizersare not dependent on the actual function implementations so ensuring the crate doesn't have dependency will let the compiler ensure thisWhat changes are included in this PR?
Remove the dependency
Are these changes tested?
Are there any user-facing changes?