Uh oh!
There was an error while loading. Please reload this page.
Move EnforceSorting into datafusion-physical-optimizer crate - #14219
Conversation
7732010 to
61fbe14Compareburaksenn
commented
Jan 21, 2025
I've these errors in replace in Not sure why but projection changes so I'm working on fixing it |
61fbe14 to
fef3c6eCompareburaksenn
commented
Jan 21, 2025
berkaysynnada
commented
Jan 21, 2025
There are two function having the same name (stream_exec_ordered), one in replace_with_order_preserving_variants.rs with a built-in projection, and one in core/src/test/mod.rs, w/o a projection, which differs the test results. You've mixed up them. I guess you've deleted one of them actually. |
a1b2197 to
9c40e49Compare
alamb
left a comment
There was a problem hiding this comment.
Thank you @buraksenn and @berkaysynnada
I did some spot checks on this PR and I think it looks EPIC -- very nice. The fact that no plans change gives me confidence the refactoring is good.
I took the liberty of pushing a commit that removed a chance to the datafusion-testing pin:

But otherwise I think this is ready to merge. I will leave it open a bit longer to give @berkaysynnada a chance to comment if they want.
xudong963
left a comment
There was a problem hiding this comment.
I did some random checks, lgtm
berkaysynnada
commented
Jan 22, 2025
LGTM, thank you @buraksenn. I'll continue with the #14190 |
alamb
commented
Jan 22, 2025
EPIC |
Which issue does this PR close?
Closes#14185
Rationale for this change
Extract remaining physical optimizer out of core
What changes are included in this PR?
Move EnforceSorting out of core package
Are these changes tested?
Existing tests that were moved to integration tests