Uh oh!
There was an error while loading. Please reload this page.
refactor: remove uses of arrow_buffer & arrow_array and use reexport in arrow instead - #14495
Closed
Chen-Yuan-Lai wants to merge 1 commit into
Closed
refactor: remove uses of arrow_buffer & arrow_array and use reexport in arrow instead#14495Chen-Yuan-Lai wants to merge 1 commit into
arrow_buffer & arrow_array and use reexport in arrow instead#14495Chen-Yuan-Lai wants to merge 1 commit into
Conversation
arrow_buffer & arrow_array with reexport in arrowarrow_buffer & arrow_array and use reexport in arrow insteadChen-Yuan-Lai
commented
Feb 5, 2025
ContributorAuthor
I wrongly deleted this branch, please review the new PR #14503 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes#14115.
Rationale for this change
As 14115 issue comment says, we should use reexport in
arrowas much as possible.What changes are included in this PR?
use arrow_buffer:: xxx->use arrow::buffer::xxxuse arrow_array:: xxx->use arrow::array::xxxI leave some imports as it is when those modules weren't reexported in
arrowAre these changes tested?
Are there any user-facing changes?