Uh oh!
There was an error while loading. Please reload this page.
Support Limit pushdown for MemoryExec - #14502
Closed
zjregee wants to merge 2 commits into
Closed
Conversation
zjregeeforce-pushed
the
impl-fetch-limit-for-memory-exec
branch
from
February 5, 2025 09:43
02efd60 to
13a0960Comparezjregeeforce-pushed
the
impl-fetch-limit-for-memory-exec
branch
from
February 5, 2025 10:48
13a0960 to
38edfcfComparealamb
reviewed
Feb 5, 2025
| projection: Option<Vec<usize>>, | ||
| /// Index into the data | ||
| index: usize, | ||
| /// The remaining number of rows to return |
Contributor
There was a problem hiding this comment.
Suggested change
| /// The remaining number of rows to return | |
| /// The remaining number of rows to return. If None, all rows are returned |
Comment on lines
+548
to
+552
| if self.fetch.is_none() { | ||
| return Poll::Ready(Some(Ok(batch))); | ||
| } | ||
| let fetch = self.fetch.unwrap(); |
Contributor
There was a problem hiding this comment.
I think you can write this more concisely and avoid the unwrap with something like
Suggested change
| ifself.fetch.is_none(){ | |
| returnPoll::Ready(Some(Ok(batch))); | |
| } | |
| let fetch = self.fetch.unwrap(); | |
| letSome(&fetch) = self.fetch.as_ref()else{ | |
| returnPoll::Ready(Some(Ok(batch))); | |
| }; |
| 05)--------MemoryExec: partitions=1, partition_sizes=[1] | ||
| 06)------GlobalLimitExec: skip=0, fetch=10 | ||
| 07)--------MemoryExec: partitions=1, partition_sizes=[1] | ||
| 04)------MemoryExec: partitions=1, partition_sizes=[1], limit=1 |
alamb
approved these changes
Feb 5, 2025
ozankabak
commented
Feb 5, 2025
Contributor
@alamb, this is subsumed by the unified source PR. Let's only merge this if we encounter an issue that will delay the other one, but let's hold off otherwise to avoid conflicts |
MemoryExecalamb
commented
Feb 5, 2025
Contributor
Sounds good FWIW I think @ozankabak is talking about this PR: |
alamb
commented
Feb 6, 2025
Contributor
zjregee
commented
Feb 7, 2025
MemberAuthor
It seems that the suggestions mentioned here are still feasible. I will use a follow on PR to add this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes#14337.
Rationale for this change
What changes are included in this PR?
Implement limit pushdown for MemoryExec, add unit test and modify outdated content in .slt test files.
Are these changes tested?
Yes.
Are there any user-facing changes?
None.