Improve error messages to include the function name.

[Omega359]

Which issue does this PR close?

• Closes #.

Rationale for this change

Function signature error messages do not include the function name making for debugging issues very difficult in a system with dataframes with hundreds of function calls.

What changes are included in this PR?

Updated error messages and tests.

Are these changes tested?

Yes

Are there any user-facing changes?

Unless you count updated error messages, no.

[alamb]

Thank you 💯 so much @Omega359 -- this is much better.

I made some suggestions to improve the wording of the errors but we can do that as a follow on PR (or never). This PR is already much better than it was

[comphead]

I would prefer the function name to be highlighted some how, it can uppercase or square brackets, otherwise the function name got lost in the message

[Omega359]

I would prefer the function name to be highlighted some how, it can uppercase or square brackets, otherwise the function name got lost in the message

1. Function test expects NativeType::Numeric but received NativeType::String
2. Function [test] expects NativeType::Numeric but received NativeType::String
3. Function TEST expects NativeType::Numeric but received NativeType::String
4. Function 'TEST' expects NativeType::Numeric but received NativeType::String
5. Function 'test' expects NativeType::Numeric but received NativeType::String

my preference is the last version.

[comphead]

I would prefer the function name to be highlighted some how, it can uppercase or square brackets, otherwise the function name got lost in the message

1. Function test expects NativeType::Numeric but received NativeType::String
2. Function [test] expects NativeType::Numeric but received NativeType::String
3. Function TEST expects NativeType::Numeric but received NativeType::String
4. Function 'TEST' expects NativeType::Numeric but received NativeType::String
5. Function 'test' expects NativeType::Numeric but received NativeType::String

my preference is the last version.

Yeah, love it. Function name is not allowed to include special characters so it should be good

[Omega359]

Any other opinions on the function name highlight version? I'll wait to do the work till eod today in case there is a good reason not to go with # 5

[comphead]

lgtm thanks @Omega359

[davisp]

Just a +1 for going with option #5 on adding single quotes around the function name. Otherwise I'm +1.

[Omega359]

Updates applied.

[comphead]

Thanks everyone!

[alamb]

Along with this PR from @Lordworms DataFusion error messages are getting downright friendly!

• feat: add hint for missing fields #14521