Skip to content

Fix Clippy 1.85 warnings - #14800

Merged
alamb merged 1 commit into
apache:mainfrom
mbrobbel:clippy-1.85
Feb 21, 2025
Merged

Fix Clippy 1.85 warnings#14800
alamb merged 1 commit into
apache:mainfrom
mbrobbel:clippy-1.85

Conversation

@mbrobbel

@mbrobbelmbrobbel commented Feb 20, 2025

Copy link
Copy Markdown
Member

Which issue does this PR close?

Rationale for this change

Rust 1.85 was released.

What changes are included in this PR?

Clippy 1.85 warning fixes.

Are these changes tested?

In CI.

Are there any user-facing changes?

No.

@github-actionsgithub-actionsBot added sql SQL Planner physical-expr Changes to the physical-expr crates core Core DataFusion crate execution Related to the execution crate labels Feb 20, 2025
@jonahgao

Copy link
Copy Markdown
Member

It seems we should also update rustfmt.toml to let CI use the new version.

@alamb

Copy link
Copy Markdown
Contributor

Thanks @mbrobbel and @Dandandan

I filed a ticket to track the work to update to latest rust

@alamb
alamb merged commit faace2c into apache:mainFeb 21, 2025
@mbrobbel
mbrobbel deleted the clippy-1.85 branch February 21, 2025 11:59
@mbrobbel

Copy link
Copy Markdown
MemberAuthor

Update to rust 1.58 #1557

I think you meant to link #14808.

@alamb

Copy link
Copy Markdown
Contributor

Yes, you are right 🤦 -- thank you

ozankabak pushed a commit to synnada-ai/datafusion-upstream that referenced this pull request Feb 25, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coreCore DataFusion crateexecutionRelated to the execution cratephysical-exprChanges to the physical-expr cratessqlSQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mbrobbel@jonahgao@alamb@Dandandan