Skip to content

support comparison for decimal data type and refactor the binary coercion rule - #1483

Merged
alamb merged 7 commits into
apache:masterfrom
liukun4515:comparsion_decimal_support
Jan 14, 2022
Merged

support comparison for decimal data type and refactor the binary coercion rule#1483
alamb merged 7 commits into
apache:masterfrom
liukun4515:comparsion_decimal_support

Conversation

@liukun4515

@liukun4515liukun4515 commented Dec 24, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

part of #122

  • refactor the coercion rule for binary operation: it's helpful to extend other operations for binary.
  • support comparison operation for decimal type.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@liukun4515liukun4515 changed the title support comparison for decimal data typesupport comparison for decimal data type and refactor the binary coercion ruleDec 24, 2021
This was referenced Dec 24, 2021
Closed
Merged
@liukun4515
liukun4515force-pushed the comparsion_decimal_support branch from 1684d63 to ed8ef8fCompareDecember 26, 2021 06:14
liukun4515
liukun4515 commented Dec 27, 2021
View reviewed changes
Comment threaddatafusion/src/physical_plan/expressions/binary.rs

/// Coercion rules for all binary operators. Returns the output type
/// of applying `op` to an argument of `lhs_type` and `rhs_type`.
fn common_binary_type(

@liukun4515liukun4515Dec 27, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move the main code to the file of binary_rule.rs.

@liukun4515
liukun4515 marked this pull request as ready for review January 13, 2022 04:21
@liukun4515liukun4515 mentioned this pull request Jan 13, 2022
Merged
@alamb

alamb commented Jan 13, 2022

Copy link
Copy Markdown
Contributor

I will review this tomorrow if no one else gets to it first. I ran out of time for today to review code

@liukun4515

liukun4515 commented Jan 14, 2022

Copy link
Copy Markdown
ContributorAuthor

I will review this tomorrow if no one else gets to it first. I ran out of time for today to review code

We can merge the cast/try_cast pull request first.

alamb
alamb approved these changes Jan 14, 2022
View reviewed changes

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through this pretty carefully -- nice work @liukun4515 . Thank you for the contribution

the only other thing I think would be helpful would be some end to end tests (e.g. in tests/sql) demonstrating doing operations (like adding a decimal to an int). However, I also think that would be fine to do as a follow on PR

Comment threaddatafusion/src/physical_plan/expressions/binary.rs
Comment threaddatafusion/src/physical_plan/coercion_rule/binary_rule.rs
Comment threaddatafusion/src/physical_plan/coercion_rule/binary_rule.rs
Comment threaddatafusion/src/physical_plan/expressions/coercion.rs
Comment threaddatafusion/src/physical_plan/expressions/binary.rs
Comment threaddatafusion/src/physical_plan/expressions/binary.rs
Comment threaddatafusion/src/physical_plan/expressions/binary.rs
@alamb
alamb merged commit 1c39f5c into apache:masterJan 14, 2022
@liukun4515

liukun4515 commented Jan 17, 2022

Copy link
Copy Markdown
ContributorAuthor

eview this tomorrow if no one else g

tracked in the subtask #122 (comment)

@liukun4515liukun4515 mentioned this pull request Jan 17, 2022
Closed
@liukun4515
liukun4515 deleted the comparsion_decimal_support branch January 17, 2022 04:10
@liukun4515liukun4515 mentioned this pull request Apr 15, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alambalambalamb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liukun4515@alamb